azerothcore / mod-cfbg

Cross-faction Battleground for AzerothCore
MIT License
13 stars 42 forks source link

Group queue causes imbalanced teams #104

Open Annamaria-CC opened 2 years ago

Annamaria-CC commented 2 years ago

What client do you play on?

enUS

Faction

Content Phase:

Current Behaviour

When queuing for an ongoing battleground (not tested on other BGs besides WSG), you will be immediately be able to join the battleground despite it causing an imbalance (uneven) team eg. 3v2, 4v3 etc. The included screenshots are from 3 different BGs enjoyed on the same day within a 3 hour time frame.

may 25 9pm may 25 1036pm may 25 8pm

Expected Blizzlike Behaviour

There should be system in place for not creating uneven teams, up to 7 players (per side), after which is will just add players.

Source

No response

Steps to reproduce the problem

  1. Queue into an ongoing battleground (preferably WSG)
  2. Join into a battleground that has uneven teams (3v2, 4v3, 5v4) with no checks or balances in place

Extra Notes

Could also be a general problem with the queue that gets multiplied by having group queue enabled. Originally reported https://github.com/chromiecraft/chromiecraft/issues/3536

Suggestion:

When a group queues, wait for another group to queue and add them both, instead of adding them willy nilly :)

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/7b4e1ef7d3d638f4ed182130af286a8f99528f53

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

ghost commented 2 years ago

@temperrr it's fix now, right ?

Annamaria-CC commented 2 years ago

It should be fixed ye