azerothcore / mod-cfbg

Cross-faction Battleground for AzerothCore
MIT License
13 stars 42 forks source link

Join as a Group doesn't work [$100] #12

Closed FrancescoBorzi closed 2 years ago

FrancescoBorzi commented 4 years ago

Joining as a group (party) does not work.

It would be nice if it can work and somehow try (but of course cannot guarantee) to maintain the original group members within the same team.

EDIT: there is a bounty on this issue. To consider it fixed, it MUST be properly tested and ALL corner cases should work. Including all different configurations enabled, for example:

CFBG.BalancedTeams = 1
CFBG.Include.Avg.Ilvl.Enable = 1
CFBG.Players.Count.In.Group = 2
CFBG.EvenTeams.Enabled = 1
CFBG.EvenTeams.MaxPlayersThreshold = 5
--- There is a **[$100 open bounty](https://www.bountysource.com/issues/91199193-join-as-a-group-doesn-t-work?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github).
BarbzYHOOL commented 4 years ago

it can be done by editing the core, there is a check already. If we enable grouping even with different factions (for example when crossfaction conf enabled), then it would work fine, BUT what happens if they group and the server is lacking the CFBG module? crash? need to try first

i already suggested to winfi but he doesn't care xD

Don't know how we can encapsulate this change in the module otherwise but it's probably possible?

mnclaras commented 3 years ago

@BarbzYHOOL Can I know what change is needed to do in the core? I'm so interested in group joining 👍

bronzato commented 3 years ago

im very interested in group joining to, what we need to do ? i want ppl joing as group be on same team. i know a little of programming maybe i can help if you give me some insights

FrancescoBorzi commented 3 years ago

im very interested in group joining to, what we need to do ? i want ppl joing as group be on same team. i know a little of programming maybe i can help if you give me some insights

@bronzato feel free to work on this! I can't give you further details because I haven't looked into this myself

Winfidonarleyan commented 3 years ago

Need test f01144f

n4ndo commented 3 years ago

Somebody else has tested https://github.com/azerothcore/mod-cfbg/commit/f01144fb60b077c460d043064ffc4fbd018e85c7 ¿¿??

ilsonlojr commented 3 years ago

@n4ndo its already done or WIP?

UltraNix commented 3 years ago

What is the status? It is done or not?

Winfidonarleyan commented 3 years ago

Wip

FrancescoBorzi commented 3 years ago

@Winfidonarleyan as you're busy with other things, I don't mind if @UltraNix picks this up. There is plenty of work to do for everyone anyway :) what do you say?

UltraNix commented 3 years ago

I'm not saying I'm not busy :)

Winfidonarleyan commented 3 years ago

@UltraNix You can try to fix it

55Honey commented 2 years ago

Battlegrounds seem to be starting instantly when enough players are queued. We might want to add a small delay to the start, to be able to match more players of the same party into the same BG faction.