BG scoreboard does not show the current faction

[FrancescoBorzi]

Expected behaviour:

BG scoreboard should show the right faction (the faction that the player is currently playing in the BG)

Current behaviour:

BG scoreboard showing the player's original faction

---

This also affects the Warsong Gulch Flag showed in the map

--- There is a **[$40 open bounty](https://www.bountysource.com/issues/91333902-bg-scoreboard-does-not-show-the-current-faction?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github).

[UltraNix]

As for the scoreboard - looks okay:

[Azcobu]

Had a report on the CC tracker with more on this (https://github.com/chromiecraft/chromiecraft/issues/837), specifically flag colours being incorrect. Some testing verified this, but as it appears to be a CFBG issue rather than an AC issue, copying it here.

User screenshot:

I tried with 2 x Horde and 2 x Ally teams (forcing one of each to go cross faction) and flag colours bugged out every time. In one case, when a human mage on the Ally side picked up the Horde flag, it showed as a blue flag on the map. As her ran forward and out of the Horde base, it changed on the map to the correct red. Meanwhile the faction-changed nelf druid, who was changed to a tauren, picked up the Ally flag, and it showed as red on the map.

Ally mage picks up Horde flag, it shows as blue:

The nelf swapped to a tauren picks up the Ally flag, which shows as red. The mage's blue flag has now turned red as well:

My own testing was on AC rev. b3e64d010d7e.

[FrancescoBorzi]

thanks @Azcobu , I can also 100% confirm there is a problem here.

@UltraNix would you like to look into this? in your test it probably worked by coincidence, just try with more characters and you'll see it

As for the scoreboard - looks okay:

[UltraNix]

Just commented about that scoreboard part - there is not bug with it. The second problem with flags - it's quite complicated to fix it.

[FrancescoBorzi]

Just commented about that scoreboard part - there is not bug with it.

@UltraNix there is a bug, maybe it does not happen always but I was in a BG myself recently, it was 4v4 and the scoreboard showed "3 ally and 5 horde" instead. My wild guess is that it counts the original faction of the characters instead of the one from the current cfbg game

[Azcobu]

Some footage of carried flags changing colour:

https://user-images.githubusercontent.com/81782124/121794703-a94ce580-cc49-11eb-8146-f63cca0b8a4b.mp4

In this case the colour-changing flag is being carried by a tauren druid, race changed to a nelf, who is carrying the red flag.