search

azerothcore / mod-cfbg

Cross-faction Battleground for AzerothCore
MIT License
13 stars 42 forks source link

Arathi Basin faction switching from male human warrior to male orc warrior and winning 1600-0 does not award an achievement [$15] #48

Closed ghost closed 2 years ago

ghost commented 3 years ago

Originally reported https://github.com/chromiecraft/chromiecraft/issues/305

WHAT CLIENT DO YOU PLAY ON?

FACTION
CONTENT PHASE:
CURRENT BEHAVIOUR:

When entering Arathi Basin as a male human warrior and being changed to a male orc warrior for cross faction, even after winning 1600-0 you do not receive an achievement known as "Arathi Basin Perfection".

EXPECTED BLIZZLIKE BEHAVIOUR:

Cross faction bgs are not blizzlike but what is blizzlike is to receive an achievement after doing what is necessary for it regardless of faction. https://us.battle.net/support/en/article/32063

STEPS TO REPRODUCE THE PROBLEM:
  1. Enter Arathi Basin as a male human warrior
  2. Be faction swapped into a male orc warrior
  3. Win Arathi Basin 1600-0 making sure to only cap 1 base
  4. Observe results
EXTRA NOTES:

There was no issue with internet or latency at the time, all issues I've noticed seem to be from cross faction problems. arathi 1600-0

I reproduced this issue on local AC with mod-cfbg enabled

After faction change Arathi Basing Perfection is not granted. On the other side, achievements like Arathi Basin Victory are granted: https://www.youtube.com/watch?v=SNb3eKEUOAM

I checked also if Arathi Basin Perfection is granted to side without faction change. It is: https://www.youtube.com/watch?v=6UrY8-_cwhw

It might be useful to change minimum number of players per team for arathi basin bg with this sql command:

update battleground_template set MinPlayersPerTeam = 1 where ID = 3;

To revert it back:

update battleground_template set MinPlayersPerTeam = 5 where ID = 3;
AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/8bacb39d53349f63066e84bcddb5a7f9300acb0d

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:
OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- There is a **[$15 open bounty](https://www.bountysource.com/issues/97970770-arathi-basin-faction-switching-from-male-human-warrior-to-male-orc-warrior-and-winning-1600-0-does-not-award-an-achievement?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github).
ghost commented 3 years ago

It might be similar to https://github.com/azerothcore/mod-cfbg/issues/34 - condition checking.

FrancescoBorzi commented 3 years ago

moved to the CFBG repo.

cc @Helias @Winfidonarleyan

Helias commented 3 years ago

tested recently, the bug still persist

Helias commented 2 years ago

I don't remember if I tested this issue with https://github.com/azerothcore/azerothcore-wotlk/pull/8009 We need to test it again and may close the issue.

@UltraNix if you want and have the time you could test it to get the 15$ of the bounty, no pressure ofc.

UltraNix commented 2 years ago

It's already fixed. Please, close it.