10+ players in warsong per faction [$15]

[The-GhostRider]

Originally reported https://github.com/chromiecraft/chromiecraft/issues/335

WHAT CLIENT DO YOU PLAY ON?

• [ ] enGB
• [X] enUS
• [ ] other (specify)

FACTION

• [ ] Alliance
• [ ] Horde

CONTENT PHASE:

• [ ] Generic
• [ ] 1-19
• [X] 20-29
• [ ] 30-39

CURRENT BEHAVIOUR:

10+ players in warsong.

EXPECTED BLIZZLIKE BEHAVIOUR:

Max players per faction is 10.

STEPS TO REPRODUCE THE PROBLEM:

EXTRA NOTES:

Not sure how this happened. Happen for both faction.

AC HASH/COMMIT:

https://github.com/chromiecraft/azerothcore-wotlk/commit/9d4eebc61fec3b9701ae94292e8d40962804b676

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:

• mod-cfbg
• mod-duel-reset
• mod-desertion-warnings
• mod-ah-bot
• mod-eluna-lua-engine
• lua-LevelUpReward

OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

--- There is a **[$15 open bounty](https://www.bountysource.com/issues/98051715-10-players-in-warsong-per-faction?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F146727645&utm_medium=issues&utm_source=github).

[FrancescoBorzi]

Indeed this is an issue as it should respect the MaxPlayersPerTeam value given in battleground_template, which by default is 10 for Warsong Gulch. And we haven't changed that value, so it' supposed to be 10.

However, I'm not sure if this is a core bug, probably it's related to the CFBG module and not with the core itself.

Can anyone confirm? cc @Winfidonarleyan

[Winfidonarleyan]

Cfbg problem, i think

[Kitzunu]

In Discord it was confirmed without CFBG module

[FrancescoBorzi]

@Winfidonarleyan can you take care of this, please?

[Shineslippers]

New issue to it. Not only more people, but unbalance also. https://github.com/chromiecraft/chromiecraft/issues/2316

[Eronox]

Indeed this is an issue as it should respect the MaxPlayersPerTeam value given in battleground_template, which by default is 10 for Warsong Gulch. And we haven't changed that value, so it' supposed to be 10.

Doesn't seem to be a matter of flawed logic, per my testing for queue'ing this is my results:

(WG changed to min/max 1-1 instead of 5-10)

Players (all level 32)

Player1 - Alliance
Player2 - Horde
Player3 - Horde

1. Player 2 queues for WSG - No BG
2. Player 3 queues for WSG - No BG
3. Player 1 queues for WSG - BG starts , featuring player 2 & 1 - Player3 moved to a new WSG queue

Instead, this seems to be caused by an edge case somewhere. Like if max queues are met or if something is going weird with premade group queues after the CONFIG_BATTLEGROUND_INVITATION_TYPE implementation 2 years ago

[FrancescoBorzi]

New issue to it. Not only more people, but unbalance also. chromiecraft/chromiecraft#2316

we should prioritise any balancing issue,

cc @Hacki95