azerothcore / mod-cfbg

Cross-faction Battleground for AzerothCore
MIT License
14 stars 42 forks source link

feat(Queue): rework battleground queue system #97

Closed Winfidonarleyan closed 2 years ago

Winfidonarleyan commented 2 years ago

Changes:

How to test:

Issues:

Helias commented 2 years ago

for me the PR is ok, hope you tested scenarios like this https://github.com/azerothcore/mod-cfbg/pull/86#issuecomment-991655228

Nefertumm commented 2 years ago

Conflicts

GoMateoGo commented 2 years ago
  1. I set 2 players to start the battlefield

2.2 players have joined the queue and display 2 / 2

  1. You should enter the battlefield normally at this time But no

  2. Unless there is a third player in the queue, display 3 / 2 At this time, there was still no dialogue on entering the battlefield

  3. Unless one of the three players leaves the queue, the other two players will pop up the enter battlefield dialogue at this moment

GoMateoGo commented 2 years ago

CFBG.Enable = 1 CFBG.BalancedTeams = 1 CFBG.BalancedTeams.Class.LowLevel = 0 CFBG.BalancedTeams.Class.MinLevel = 10 CFBG.BalancedTeams.Class.MaxLevel = 19 CFBG.BalancedTeams.Class.LevelDiff = 2 CFBG.Include.Avg.Ilvl.Enable = 0 CFBG.Players.Count.In.Group = 3 CFBG.EvenTeams.Enabled = 0 CFBG.EvenTeams.MaxPlayersThreshold = 5 CFBG.ResetCooldowns = 1 CFBG.Show.PlayerName = 1

GoMateoGo commented 2 years ago

Supplement:

The dialog box for entering the battlefield cannot be popped up no matter how many people are involved

Unless any one in the queue leaves the queue, the enter battlefield dialog box will pop up for others in the queue