Add 4 methods - Githubissues

azerothcore / mod-eluna

Eluna Lua Engine © for WoW Emulators

https://elunaluaengine.github.io/

GNU General Public License v3.0

96 stars 126 forks source link

Add 4 methods #158

Closed worldofd2 closed 7 months ago

worldofd2 commented 10 months ago

1: Player:GetAchievementPoints

2: Player:GetCompletedQuestsCount This should have been GetCompletedQuestsCount, not sure how to update that now.

3: You also have an option to include feats of strength or not (not included by default, blizzard like) Player:GetCompletedAchievementsCount

4: RegisterPlayerEvent OnCreatureKilledByPet

55Honey commented 10 months ago

Hi and thanks for your PR. We'll look into it asap.

worldofd2 commented 10 months ago

Please let me know if a better format should be used, first time for a PR. Thank you.

kissingers commented 10 months ago

I tested 3 about achievement and question, it seems ok

        local pAchivePoint = player:GetAchievementPoints()
        local pAchiveCompleted = player:GetCompletedAchievementsCount() 
        local pCompletedQuest = player:GetCompletedQuestsCount()            
        player:SendBroadcastMessage("Your achievement points is "..pAchivePoint)
        player:SendBroadcastMessage("you completed "..pAchiveCompleted.." achievements")
        player:SendBroadcastMessage("you completed "..pCompletedQuest.." quests (without everyday quests)")