search

azerothcore / mod-eluna

Eluna Lua Engine © for WoW Emulators
https://elunaluaengine.github.io/
GNU General Public License v3.0
96 stars 126 forks source link

Fix unused variable warning in GlobalMethods:Ban() #183

Closed sudlud closed 2 months ago

55Honey commented 2 months ago

Let's get rid of what's not required for AC all together.

There was a reorganisation of the Eluna master repo. Each core now has its own set of files without the need of ifdefs in each file. That's to be ported, but we can start anywhere.

sudlud commented 2 months ago

@55Honey i'm reworking this to drop all non-AC-relevant code so we will get rid of most #if #else #endif blocks

should I go as far as assuming we are at AZEROTHCORE with WOTLK beeing set and remove any code related to e.g. CLASSIC/TBC/MISTS/MANGOS/TRINITY/...?

there's a lot of switches depending on the expansion define, but for AC this would always be set to WOTLK?

or would this go too far?

55Honey commented 2 months ago

In short: yes.

There was a closed PR lately, which wasn't merged because it was closed before we had a chance to review it, which claimed to remove all the ifdefs. I am not sure if you can dig it up so we can diff-merge.

sudlud commented 2 months ago

alright then i might need to revisit this within the next days, for now it removes almost all #if blocks