search

azerothcore / mod-eluna

Eluna Lua Engine © for WoW Emulators
https://elunaluaengine.github.io/
GNU General Public License v3.0
96 stars 126 forks source link

drop AC-unrelated code within #if blocks #186

Open sudlud opened 2 months ago

55Honey commented 1 month ago

What happened to Shade of Aran? 🙈 

/home/runner/work/mod-eluna/mod-eluna/src/server/scripts/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp:127:27: fatal error: comparison of integers of different signs: 'int' and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-compare]
        for (int i = 0; i < immuneSpells.size(); i++)
                        ~ ^ ~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:1994: src/server/scripts/CMakeFiles/scripts.dir/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp.o] Error 1
sudlud commented 1 month ago

What happened to Shade of Aran? 🙈 


/home/runner/work/mod-eluna/mod-eluna/src/server/scripts/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp:127:27: fatal error: comparison of integers of different signs: 'int' and 'std::vector::size_type' (aka 'unsigned long') [-Wsign-compare]

        for (int i = 0; i < immuneSpells.size(); i++)

                        ~ ^ ~~~~~~~~~~~~~~~~~~~

1 error generated.

make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:1994: src/server/scripts/CMakeFiles/scripts.dir/EasternKingdoms/Karazhan/boss_shade_of_aran.cpp.o] Error 1

I'll re-run CI