search

azerothcore / mod-eluna

Eluna Lua Engine © for WoW Emulators
https://elunaluaengine.github.io/
GNU General Public License v3.0
96 stars 127 forks source link

Update GlobalMethods.h #96

Closed TVBrowntown closed 1 year ago

TVBrowntown commented 1 year ago

Update GetGOData to GetGameObjectData for latest commit: dba8c49bce9aa93110730e60dc9446ca002fa68f

55Honey commented 1 year ago

Thanks for your PR. I just pulled AC and mod-eluna and compiled without errors. Can you please provide re-production steps for the error which make this change necessary?

TVBrowntown commented 1 year ago

Thanks for your PR. I just pulled AC and mod-eluna and compiled without errors. Can you please provide re-production steps for the error which make this change necessary?

Sure, here is how I did it before.

pull commit https://github.com/azerothcore/azerothcore-wotlk/commit/dba8c49bce9aa93110730e60dc9446ca002fa68f for azerothcore-wotlk. pull mod-eluna and place into azerothcore-wotlk/modules.

should fail/error to build since https://github.com/azerothcore/azerothcore-wotlk/commit/dba8c49bce9aa93110730e60dc9446ca002fa68f has updated a function name that mod-eluna utilises.

If it still works for you then I guess this can be disregarded :)

AnchyDev commented 1 year ago

This PR was merged yesterday that should have fixed this. It should be okay to close this issue. :)

55Honey commented 1 year ago

This PR was merged yesterday that should have fixed this. It should be okay to close this issue. :)

That's what I thought as well. Thanks for confirming it!