azerothcore / mod-emblem-transfer

AzerothCore module. Transfer your emblems to another character in your account.
GNU Affero General Public License v3.0
6 stars 14 forks source link

Error when inserting in the database #2

Closed pangolp closed 5 years ago

pangolp commented 5 years ago

Greetings people. Yesterday I was testing the module, the truth is that the idea is great, but I found a mistake. I tried to transfer emblems to another character and I found that there were no errors, however, when the other person wanted to claim them, he told me that there was no item with id 0, so I went to the database and found the following.

I found by all means, the way to correct it, but I did not find the return really, nose that is failing, evidently the problem is perhaps in the INTO INSERT, but I could not.

On the other hand, I was thinking that it would be interesting to have another table, where before removing the emblems, save the transfer. In case an error like this occurs, know how many emblems were erased from the character.

Because if it happens in an online server, it could be a difficult problem to correct I think. Then it wouldn't be wrong to have a backup of the erased emblems.

I hope the information will help you, I'm sorry I can't help you any more.

ZeegCL commented 5 years ago

What's your azerothcore hash?

ZeegCL commented 5 years ago

Please test again after updating to 63a158a8f67655c74acba24f6fc64116aa5a5827

pangolp commented 5 years ago

I'm sorry I never tried it, the problem is that I leave my server a little bit because of population issues.