search

azerothcore / mod-emblem-transfer

AzerothCore module. Transfer your emblems to another character in your account.
GNU Affero General Public License v3.0
6 stars 14 forks source link

Bug: Compilation Failure #32

Open F-Lambda opened 6 days ago

F-Lambda commented 6 days ago

Current Behaviour

Module is no longer compatible with current version of AzerothCore. Now receives the following errors:

Severity    Code    Description Project File    Line    Suppression State   Details
Error   C2039   'SendNotification': is not a member of 'WorldSession'   modules D:\AzerothCore\modules\mod-emblem-transfer\src\npc_emblem_transfer.cpp  244     
Error   C2039   'SendNotification': is not a member of 'WorldSession'   modules D:\AzerothCore\modules\mod-emblem-transfer\src\npc_emblem_transfer.cpp  124     
Error   C2039   'SendNotification': is not a member of 'WorldSession'   modules D:\AzerothCore\modules\mod-emblem-transfer\src\npc_emblem_transfer.cpp  135     
Error   C2039   'SendNotification': is not a member of 'WorldSession'   modules D:\AzerothCore\modules\mod-emblem-transfer\src\npc_emblem_transfer.cpp  178     
Error   C2039   'SendNotification': is not a member of 'WorldSession'   modules D:\AzerothCore\modules\mod-emblem-transfer\src\npc_emblem_transfer.cpp  199     
Error   C2039   'SendNotification': is not a member of 'WorldSession'   modules D:\AzerothCore\modules\mod-emblem-transfer\src\npc_emblem_transfer.cpp  237

Expected Behaviour

Module compiles.

Steps to reproduce the problem

Attempt to compile with current AzerothCore.

Extra Notes

No response

AC rev. hash/commit

null, compile fails

Operating system

Windows 11 x64

Custom changes or Modules

No response

F-Lambda commented 5 days ago

The above pull request fixes compilation. However, the module still needs some more updating, due to database changes and the removel of the modelid1 column (described in another module here: https://github.com/azerothcore/mod-guildhouse/issues/54#issuecomment-2359243492 )