search

azerothcore / mod-individual-xp

GNU Affero General Public License v3.0
17 stars 22 forks source link

Update travis #10

Closed talamortis closed 4 years ago

talamortis commented 5 years ago

Updated to see if travis will compile

Closes https://github.com/azerothcore/mod-individual-xp/issues/9

talamortis commented 5 years ago

Yeah, I'll look at it when I got more time

BarbzYHOOL commented 5 years ago

i don't know, i feel like the testers didn't properly test

So I enabled travis to see if it compiles there but not sure how to make it show up in the PR

BarbzYHOOL commented 4 years ago

lol the build completely failed

BarbzYHOOL commented 4 years ago

https://github.com/azerothcore/skeleton-module/blob/master/.travis.yml

talamortis commented 4 years ago

yeah ill fix when i get more time

pangolp commented 4 years ago

What would be missing to finalize this pull request?

BarbzYHOOL commented 4 years ago

need to update the travis file, see if it compiles and then fix ?

have you tested it @pangolp ?

wizzymore commented 4 years ago

https://github.com/azerothcore/mod-individual-xp/pull/12 should fix the travis problems and help you better debug the module

pangolp commented 4 years ago

What is the problem that generates in travis and how can I test it?

wizzymore commented 4 years ago

What is the problem that generates in travis and how can I test it?

There is no problem with travis module-specific, is just it is not correctly set-up.

As for this pr, this pr is resolving a linux only error:

-void OnGiveXP(Player* p, uint32& amount, Unit* victim) override
+void OnGiveXP(Player* p, uint32& amount, Unit* /*victim*/) override

Doing this change might make linux compiling of the module work, but can't know this as travis doesn't currently work and no one tested the real change

wizzymore commented 4 years ago

Hi @talamortis, thank you so much for your contribution.

You can find the complete pull request that fixed travis here: https://github.com/azerothcore/mod-individual-xp/pull/14