search

azerothcore / mod-individual-xp

GNU Affero General Public License v3.0
17 stars 22 forks source link

Fixing script commands #15

Closed wizzymore closed 4 years ago

wizzymore commented 4 years ago

Fixing the command handlers and adding errors so the user knows what is happening when using the commands

Adding help messages for the players.

This closes: https://github.com/azerothcore/mod-individual-xp/pull/11 https://github.com/azerothcore/mod-individual-xp/pull/10 https://github.com/azerothcore/mod-individual-xp/issues/9 https://github.com/azerothcore/mod-individual-xp/issues/16

Thank you everyone for your pull requests but the problem was way deeper than that as the handlers were not done properly from the beginning

credits to: @pangolp @talamortis @milestorme

milestorme commented 4 years ago

Legend I knew this could be done better 🤙😉

wizzymore commented 4 years ago

Legend I knew this could be done better 🤙😉

Still, look at this commit, i am laughing my ass off 'cause from one unused variable i added 4 more xD https://github.com/azerothcore/mod-individual-xp/pull/15/commits/bebbf154544a9f52d3a8f106c2c87db5e3f09e8b

milestorme commented 4 years ago

You good with the db_assembler that will need to be done for travis to pass too Check my closed pr for config.sh and include.sh