feat(cpp): Rate now relative to the worldserver's one + Accept float + refactor

BarbzYHOOL commented 4 years ago

Changes

Changed it to work based on the worldserver.conf xp-rate, so maximum you can set is dictated by that
Accepts float instead of integer only
Changed it so that players who set their XP back to the default rate gets deleted from the database, so that there's no longer data filling the database of players using the default XP rate
Removed not very useful subcommands (not sure if good idea though, needs testing before and after)

Testing

This PR requires TESTING:

please test without the PR first and see how usable it is and how pratical all the commands are (.xp default etc...)
please test with this PR and see if the missing commands are needed or not at all

I haven't tested mostly because I don't use this module for now. It's not my work (apart from small things like the readme, the conf, the sql, and keeping the announce function) it's work done by @malow as written in the commit.

Updating

If you already have these commands in your DB and you are satisfied with this PR (or if this PR gets merged), then you can remove the useless commands from your DB:

xp default
xp enable
xp disable

Mamaro89 commented 4 years ago

Sorry but i might missunderstood this post... i'm having a problem with Pets XP:

The Module brings the XP configured on worldserver.conf, mine is 1. Then i changed the module configs to alow from one 1 7, being 7 default. So when a new char is created it has the (7 x 1) xp (module x 'xp set on worldserver) But.. the module doesnt multiple the pet XP

So while i'm leveling on 7x XP, my pet still gets 1x xp from everything.. Can you pls fix it?

pangolp commented 1 year ago

Sorry, but I am going to close this PR. If you think I am wrong, feel free to let me know. But I think the things you want to correct here, for the vast majority of them, have already been fixed in other applications. But if you think I'm wrong, let me know and we'll review it right away.

pangolp commented 1 year ago

Sorry but i might missunderstood this post... i'm having a problem with Pets XP:

The Module brings the XP configured on worldserver.conf, mine is 1. Then i changed the module configs to alow from one 1 7, being 7 default. So when a new char is created it has the (7 x 1) xp (module x 'xp set on worldserver) But.. the module doesnt multiple the pet XP

So while i'm leveling on 7x XP, my pet still gets 1x xp from everything.. Can you pls fix it?

Does this really happen? Please, if so, I ask you to create an issue, to see if we can solve it somehow. Because that PR, we are going to close it. Unless the owner of it, considers that it should be opened again. Thanks.

azerothcore / mod-individual-xp