search

azerothcore / mod-progression-system

ChromieCraft Progression System
GNU Affero General Public License v3.0
56 stars 55 forks source link

Lock Sapphiron's Chamber in Naxxramas until all wings are cleared #308

Open Gultask opened 1 year ago

Gultask commented 1 year ago

This was a requirement up until Patch 3.3.0

Could this maybe be done through conditions?

https://github.com/azerothcore/azerothcore-wotlk/pull/15048

55Honey commented 1 year ago

I don't see BOSS_STATE as a condition and i also don't see area triggers in types. Maybe CONDITION_SOURCE_TYPE_SPELL could work ad type, but there's still no condition i can think off.

Nyeriah commented 1 year ago

It can't, you'll need to replicate the instance file as done with UBRS/MC, not something you should be bothering with until you actually need because quite frankly maintaining those duplicated files is a pain in the ass and the file itself is in a bad shape currently and will likely suffer many changes from now to 1-2 years when CC will actually need it.

55Honey commented 1 year ago

I'm thinking of a conf option to be honest, in the core.

Nyeriah commented 1 year ago

I’ll disagree with this as then you fundamentally have no reason not to implement every other progression change straight into the core and that’s not something we wish for, it’s the reason why this module was created in the first place