azerothcore / mod-progression-system

ChromieCraft Progression System
GNU Affero General Public License v3.0
59 stars 56 forks source link

Level 70 quest money reward calculates with level 80 exp values #352

Closed ghost closed 10 months ago

ghost commented 1 year ago

CC report: https://github.com/chromiecraft/chromiecraft/issues/6114

What client do you play on?

enUS

Faction

Both

Content Phase:

70

Current Behaviour

Currently every level 60+ quest you complete in Outland calculates with incorrect quest exp value at lvl 70 (which is the value then converted to gold with a formula of 1 xp = 6 copper as confirmed on wotlk classic) For example, a level 68 quest that should award 10k exp to a level 70, only gives 1k exp worth of money (~60 silver), which is the amount a level 80 player would receive for completing this quest, not level 70. (This is further cut by the server settings, but that issue belongs to the Suggestions)

Expected Blizzlike Behaviour

As long as the level cap is lvl 70, players at lvl 70 should receive bonus money based on the experience a level 70 character would get completing each quest.

Level 65-70 quests should award full exp to a level 70, and therefore full monetary reward scaling with the exp they give (For example: 10k exp=6 gold, formula has been confirmed on wotlk classic by Bench) Level 64 quests should award 80% of their exp to a level 70, and therefore a slightly smaller monetary reward (in case of a quest that awards 10k exp at lvl 64, this would be 8k exp converted to gold = 4,8gold) Level 63 quests should award 60% of their exp to a level 70, and therefore an even smaller monetary reward (in case of a quest that awards 10k exp at lvl 63, this would be 6k exp converted to gold = 3,6 gold) Level 62 quests should award 40% of their exp to a level 70, and therefore an adequately smaller monetary reward (in case of a quest that awards 10k exp at lvl 62, this would be 4k exp converted to gold = 2,4gold) Level 61 quests should award 20% of their exp to a level 70, and therefore once again a smaller monetary reward (in case of a quest that awards 10k exp at lvl 61, this would be 2k exp converted to gold = 1,2 gold) Level 60 quests and below should award 10% of their exp to a level 70, which is the minimum exp reward you get from gray-level quests, and this minimum value should be converted to gold (in case of a level 60 quest that awards 10k exp at lvl 60, this would be 1k exp converted to gold = 60 silver)

Source

See https://wowwiki-archive.fandom.com/wiki/Experience_point#Quest_XP for how quest exp is calculated

Formula for gold at max lvl: Money in copper = XP * 6

( confirmed on wotlk classic by Bench)

Steps to reproduce the problem

Make a level 70 character .char level 70 Teleport to any lvl 65+ quest location, for example .tele shadowmoon Check the monetary reward awarded by a level 65+ quest, for example https://www.wowhead.com/wotlk/quest=10660/what-strange-creatures Notice this quest awards 4g10s on top of the 12300 experience it's supposed to get. As a level 70, you cannot currently gain experience, so this 12300 should be converted to gold, which makes 73800 copper or 7g38s with the confirmed formula. This means the quest should award a total of 11g48s to you. The actual value you see is 4g47s50c, which means removing the 4g10s gold reward you would get on top of the exp, you only receive 37,5silver from the 12300 experience it awards. This is for 2 reasons: 1) the server calculates with a level 80's XP value, which is only 1250 (gray quest) instead of a level 70 that you are (this is a bug) 2) the server has an arbitrary ~1/4 money reward cut in place due to staff choice (this is a feature)

Extra Notes

This is an issue specific to CC, due to the temporary level 70 cap.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/280822cb8350213f374e59741506a607ce17dcaa

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft