azerothcore / mod-progression-system

ChromieCraft Progression System
GNU Affero General Public License v3.0
57 stars 56 forks source link

Classic changed Enchanting Recipes #61

Open Hacki95 opened 2 years ago

Hacki95 commented 2 years ago

Arbitration made me aware of an issue we will face in the 50-60 bracket.

Most of the classic enchantments for caster classes got changed with wotlk, while they required items like "nexus crystals" before (disenchanted from classic items) they now require "prismatic shards" (disenchanted from TBC items only).

This is true for most other ingredients as well (Elemental items, Dust etc). Is it possible to change the requirements in a recipe? Not without Core edits right? What are our possibilities here?

1) Try to change back the recipes to classic

From my understanding since these spells are saved in the client there is no simple way to just overwrite these with sql values in the DB. If I am wrong please correct me here but I think this would require a custom patch.

2) Make an exchange vendor

We would need to find out if there is an almost 1:1 way to exchange the materials to the classic values. Like @Yehonal said this might be possible to do without core edits but I am not sure.

3) Make an exchange gossip NPC

If the option of using a normal vendor doesn't work we could script a simple exchange gossip NPC. Same principle as for option 2, we would need to research first if the items can be exchanged 1:1

So what should we do??

We need to find someone who has the time to compare the classic recipes with the changed ones to find out how we could exchange the items accordingly because from my understanding changing the recipes would mean too much work and a custom patch. So option 2 looks like the preferred method.

Shineslippers commented 2 years ago

Enchanting

There is only recipes that changed mats to TBC one.

Recipe Old Current
25072 Gloves - Threat 4xNC 6xLBS 8xLarval Acid 4xSPS 2xGPE 8xPrimal Life
25073 Gloves - Shadow Power 3xNC 10xLBS 6xEssence of Undeath 3xSPS 10xLBS 6xEssence of Undeath
25074 Gloves - Frost Power 3xNC 10xLBS 4xEssence of Water 3xSPS 10xLBS 4xEssence of Water
25078 Gloves - Fire Power 2xNC 10xLBS 4xEssence of Fire 2xSPS 10xLBS 4xEssence of Fire
25079 Gloves - Healing Power 3xNC 8xLBS 1xRighteous Orb 3xSPS 8xLBS 1xRighteous Orb
25080 Gloves - Superior Agility 3xNC 8xLBS 4xEssence of Air 3xSPS 3xGPE 2xPrimal Air
25081 Cloak - Greater Fire Resistance 3xNC 8xLBS 4xEssence of Fire 3xSPS 3xGPE 4xEssence of Fire
25082 Cloak - Greater Nature Resistance 2xNC 8xLBS 4xLiving Essence 2xSPS 3xGPE 4xLiving Essence
25083 Cloak - Stealth 3xNC 8xLBS 2xBlack Lotus 3xSPS 3xGPE 2xFel Lotus
25084 Cloak - Subtlety 4xNC 6xLBS 2xBlack Diamond 4xSPS 2xGPE 8xPrimal Shadow
25086 Cloak - Dodge 3xNC 8xLBS 8xGuardian Stone 3xSPS 3xGPE 8xPrimal Earth

Possible Ratio. Primal Shadow not so trashy to exchange 1x4, but this is debatable.

Old Ratio Current
Nexus Crystal 1x1 Small Prismatic Shard
Large Brilliant Shard 3x1 Greater Planar Essence
Guardian Stone 1x1 Primal Earth
Black Lotus 1x1 Fel Lotus
Black Diamond ?x? Primal Shadow
Essence of Air 2x1 Primal Air
Larval Acid 1x1 Primal Life
UltraNix commented 2 years ago

There is no option to change reagents without clientside modifications. Also - an exchange vendoris not a good choice - people can abuse and farm mats, exchange for TBC mats and then wait till TBC release. It would kill AH/economy.

55Honey commented 2 years ago

There is no option to change reagents without clientside modifications. Also - an exchange vendoris not a good choice - people can abuse and farm mats, exchange for TBC mats and then wait till TBC release. It would kill AH/economy.

Good point, but we can just run a query and convert them all back during the update from vanilla to BC.

https://github.com/55Honey/Acore_ExchangeNpc Here is the first draft of the NPC. Values are only for testing. There's a NPC Insert query missing in it for the creature_template table.

UltraNix commented 2 years ago

Good point, but we can just run a query and convert them all back during the update from vanilla to BC. Sounds like a good cause of drama :)

Of course, people just can farm these mats, exchange and sell to vendor to make money - it's another example.

55Honey commented 2 years ago

We need to make it clear that the Mats would be converted back from the start. That's the best we can do.

UltraNix commented 2 years ago

And what about money? Of course, people just can farm these mats, exchange and sell to vendor to make money - it's another example. I think it's not a best idea.

55Honey commented 2 years ago

That sounds like we need to lower the vendor value of the BC items / set it to 0 temporarily. Good point actually!

UltraNix commented 2 years ago

@55Honey We want a new exchange vendor for that?

55Honey commented 2 years ago

We can add all of these mats to the one that exists. We'll test it asap and adjust the values/mats.

UltraNix commented 2 years ago

"The one that exists" - which is...?

55Honey commented 2 years ago

This one :)

There is no option to change reagents without clientside modifications. Also - an exchange vendoris not a good choice - people can abuse and farm mats, exchange for TBC mats and then wait till TBC release. It would kill AH/economy.

Good point, but we can just run a query and convert them all back during the update from vanilla to BC.

https://github.com/55Honey/Acore_ExchangeNpc Here is the first draft of the NPC. Values are only for testing. There's a NPC Insert query missing in it for the creature_template table.

UltraNix commented 2 years ago

@55Honey So you are working on it?

55Honey commented 2 years ago

Yes. We did some testing today. We're going to add a confirmation gossip and then it should be good to go.

55Honey commented 2 years ago

Thanks! I didn't think of that tbh :-)

55Honey commented 2 years ago

Someone, please test the PR above, and check the ratios so we can close this.

Helias commented 2 years ago

Tested, hope we can use it soon 🚀

55Honey commented 2 years ago

@Hacki95 please check the ratios. If fine, we can merge and close this. image

Shineslippers commented 2 years ago

@55Honey Can this NCP change several item to one? I mean if for full set of mats gives enchant Scroll instead of mats. Idk is this any better or not, but in this case it will not affect other proffesions. There will be only cheap enchant scrolls and don't need to care about removals.

55Honey commented 2 years ago

Sure, we could do that. But it would remove the meaning of the actual recipes from the game. People should be required to farm them in the raids.

I don't see an effect on other professions, other than the prices tbh.

Hacki95 commented 2 years ago

We should also keep in mind, before TBC is released we should convert ALL tbc materials back to classic ones if people stockpiled them. That way nobody can prefarm TBC mats.

55Honey commented 2 years ago

@Hacki95 The NPC mentions that in the confirmation dialog. The query would be manual and needs to be added to the progression repo as a one-time execution. image

Hacki95 commented 2 years ago

neat