Closed cdenq closed 1 year ago
Hello, the pull request cannot pass the tests, because the repository is out of date. If I update it, do you know how to update your branch later to test your pull request? Confirm me, to make the change inside it, and then we test your contribution.
Yes, I can update my own branch w/ the new changes and make a new PR!
I'll try to update it tonight and I'll notify you.
If this pull request passes the tests, I'll make the margin for it, and then maybe, it will have to move its branch, to make it compatible. With that, we will be able to pass the tests, and perform the test to incorporate your code, in case it solves the problem. https://github.com/azerothcore/mod-racial-trait-swap/pull/15
I did not make modifications to the script, that is supposed to be done by you. I only update the repository, so that it adapts to the new way in which the modules have today and that it is compatible with the latest version of the emulator.
Done, you just have to update your branch, and we'll run the tests again, that should be more than enough. And then, we would carry out the tests to see that your changes help to improve the problem you mention.
1. Added Missing Classes
Detailed Explanation: Non-native-to-race classes did not have a conditional to receive racials with variants. For eg, a Blood Elf paladin that is trying to switch to the Orc racial would not receive Blood Fury because: 1. the target race (Orc) did not natively support the class (Paladin) and 2. certain racials had multiple variants (Blood Fury has a variant that increases AP, increases SP, or increases both, and the one learned depends on the class). Thus, because Orc Paladins is a not a native race-class combination, there was no conditional to give a Dranei or Blood Elf paladin Blood Fury.
2. Fixed Misaligned Dranei Racial (Shaman vs Warrior)
Detailed Explanation: Previously, warriors did not receive Gift of the Naaru or Shadow Resistance at all, and Shamans received the warrior's version of these two spells. These have now been corrected.
3. Functionalized Racial Removal