azerothcore / mod-solo-lfg

Solo LFG Module for use on AzerothCore 3.3.5a
https://azerothcore.org
MIT License
40 stars 38 forks source link

[Possible Fix - Requires to be tested] Patch updated to current AzerothCore Source. #29

Closed febaut closed 2 years ago

febaut commented 2 years ago

This is a lfg-solo.patch file update.

Aims to solve the issue:

https://github.com/azerothcore/mod-solo-lfg/issues/28

Please test and give some feedback if necessary.

nolt commented 2 years ago

You have not needed tabs in 21 line

git apply modules/mod-solo-lfg/lfg-solo.patch
modules/mod-solo-lfg/lfg-solo.patch:21: trailing whitespace, tab in indent.
         if (!sLFGMgr->IsSoloLFG() && !allAnswered) 
error: corrupt patch at line 35

but even removing them still I'll get

error: corrupt patch at line 35
febaut commented 2 years ago

I've modified the patch again. Now it doesn't show the error: corrupt patch at line 35.

nolt commented 2 years ago

git apply modules/mod-solo-lfg/lfg-solo.patch


modules/mod-solo-lfg/lfg-solo.patch:21: tab in indent.
    if (!sLFGMgr->IsSoloLFG() && !allAnswered)
modules/mod-solo-lfg/lfg-solo.patch:44: tab in indent.
     /// Toggle LFG in debug mode
modules/mod-solo-lfg/lfg-solo.patch:55: tab in indent.
     bool m_isSoloLFG;                                  ///< solo lfg
modules/mod-solo-lfg/lfg-solo.patch:70: tab in indent.
     if (!sLFGMgr->IsSoloLFG() && numPlayers != MAXGROUPSIZE) // solo lfg
modules/mod-solo-lfg/lfg-solo.patch:71: tab in indent.
      {
error: patch failed: src/server/game/DungeonFinding/LFGMgr.cpp:39
error: src/server/game/DungeonFinding/LFGMgr.cpp: patch does not apply
error: patch failed: src/server/game/DungeonFinding/LFGMgr.h:553
error: src/server/game/DungeonFinding/LFGMgr.h: patch does not apply
error: patch failed: src/server/game/DungeonFinding/LFGQueue.cpp:289
error: src/server/game/DungeonFinding/LFGQueue.cpp: patch does not apply
nolt commented 2 years ago

@febaut any updates on this?