Implement this into the core directly

azerothcore / mod-solo-lfg

Solo LFG Module for use on AzerothCore 3.3.5a

https://azerothcore.org

MIT License

38 stars 36 forks source link

Implement this into the core directly #3

Closed BarbzYHOOL closed 1 year ago

BarbzYHOOL commented 4 years ago

After discussing this with several developers (Darkon, Diel, Yehonal), this module should be implemented into the core with configurable options. It's mostly about the .patch file

In top of that, we should be able to set a minimum amount of players required for the group size before being teleported to the dungeon AND a maximum amount of players as well.

EDIT: game/Groups/Group.h:30:#define MAXGROUPSIZE 5

BarbzYHOOL commented 4 years ago

If added, need to make this configurable too:

server/game/DungeonFinding/LFGMgr.h:40:    LFG_GROUP_KICK_VOTES_NEEDED                  = 3

And do it like that:

LFG_GROUP_KICK_VOTES_NEEDED = (CONFIG_LFG_VOTE_KICK_REQUIRED_NUMBER_OF_PLAYERS) ? CONFIG_LFG_VOTE_KICK_REQUIRED_NUMBER_OF_PLAYERS; ceil(CONFIG_GROUP_MAX_PLAYERS_SIZE)`

EDIT: and also it must not work if the group size = 2, else only 1 vote can kick the other player

BRNKR commented 4 years ago

elmerbud commented 4 years ago

WIP 💀

BarbzYHOOL commented 4 years ago

Another bunch of suggestions:

name is kinda misleading "solo-lfg" as we can "duo-lfg" "trio-lfg" etc xD, we need to find a better name for the config options :P (i'll help ofc)
command to toggle on/off (depending on the actual state of the feature. If server is configured by default to be active, then first command usage will toggle it off for the player in question) per player (aka current group's leader, so it works for an incomplete group too). Why? that way, when the system is set to off, a solo (or duo etc...) can join the LFG system and find random players to help them

elmerbud commented 4 years ago

I would call it lfg-insta-pop .

Configuration proposal:

LFG.insta.pop.enable - enable insta-pop on server
LFG.insta.pop.solo.enable - enable solo (no group) insta-pop on server
LFG.insta.pop.solo.command.enable - enable player .lfg insta pop solo on|off command to toggle insta pop.
LFG.insta.pop.solo.command.announce - announce state of .lfg insta pop solo on|off
LFG.insta.pop.party.enable - enable party insta-pop on server
LFG.insta.pop.party.command.enable - enable party leader.lfg insta pop party on|off command to toggle insta pop.
LFG.insta.pop.party.command.announce - announce state of .lfg insta pop party on|off
LFG.insta.pop.party.min.group.size - set limit 2,3,4

LBRS/UBRS not taken into consideration yet as they are special 10-man dungeons.

BarbzYHOOL commented 4 years ago

Better names:

lfg-instapop LFG.instapop.x.x

Questions:

why the distinction between solo and party? (i can't think well atm, maybe i don't see something that could be useful :P)

what is announce state for? what would it announce?

and how do lbrs/ubrs fit in the Random Dungeon Finder tool?

elmerbud commented 4 years ago

Because as admin you can choose to enable instapop for solo and party or just solo or just party. Depends how crazy admin is but we give him all he need.

Yes, i would remove announcer and make it by default to announce the state when you use .lfg instapop solo on|off.

I will analyze lbrs/ubrs and come back with an answer. I don't really know.

BarbzYHOOL commented 4 years ago

dunno if useful to tell the player, maybe it is, okay for the rest

pangolp commented 1 year ago

Since the issue is approximately 3 years old, I will close it, and if necessary, we will reopen it. But I want to ensure that the open issues, are currently bugs or improvements that we should apply to the module today. So if we have to reopen the issue, it is reopened, or a new updated issue is created, with all the updated information, so that we can correct the error or see the possibility of implementing what was discussed here.