search

azerothcore / mod-solocraft

Solocraft module for AzerothCore
GNU General Public License v3.0
47 stars 37 forks source link

(bugfix) CalculateDifficulty should return a `float`, not an `int` #37

Closed kjack9 closed 1 year ago

kjack9 commented 1 year ago

Either I'm an idiot (which is a distinct possibility), or CaclculateDifficulty has been silently dropping anything after the decimal point for about four years.

I only noticed this issue when I tried setting difficulties less than 1.0 and I wasn't getting an in-game message from SoloCraft at all when transferring to a dungeon.

Tested on my up-to-date AzerothCore server. Working well with difficulties between 0.0 and 1.0.

Helias commented 1 year ago

thanks for your PR, if the build pass I will merge it