azerothcore / mod-transmog

Plug&Play transmog module for AzerothCore, based on Rochet2 works
https://github.com/azerothcore/mod-transmog/blob/master/README.md
GNU Affero General Public License v3.0
119 stars 143 forks source link

Transmogrification Sets interfere with previous manual transmogrification #85

Closed ghost closed 1 year ago

ghost commented 2 years ago

Server: ChromieCraft Client: EN

Transmogrification resets to the original item appearance after re-logging when previously applying a set appearance on items that have been manually transmogrified before with the same or a different appearance. This can be avoided by first removing every previous transmogrification manually and then applying the set.

anhility commented 2 years ago

I've had the same bug regarding tmog sets and have a theory why some items revert to their normal appearances. Say you have two gear sets for you specs (outfitter or the ingame manager, whatever) but the two sets share some items between them. When applying the set appearance to the first gear set so does it seem to give a tag to the items for what appearance they should show instead. But as you apply the tmog set appearance to your second gear set it seems like the items shared between the sets get double tagged and cause the bug.

For example, let's say the pants are shared for both gear sets but not your chest. Both the pants and the chest piece get the appearance tag from applying the tmog set. But when you swap gear, your pants get a second tag of the same set appearance but now your second chest piece get its first tag. Then (my guess) is when the game is drawing your character (login/change zone/whatever) it looks for what appearance your items should have, but since you still have the same pants equipped something in the script bugs out as you no longer have the chest equipped that corresponds to the pants first appearance tag, so it defaults it back to it's original model.

ZhengPeiRu21 commented 2 years ago

There are many report of this issue but I am have trouble to cause it to happen during testing. Here is some test I have done:

  1. Create an Equipment Manager Set "White Gear"
  2. Create an Equipment Manager Set "Purple Gear"
  3. Create a saved Transmog Set "Red Gear"
  4. Equip "White Gear", transmog to "Red Gear" appearances
  5. Equip "Purple Gear", transmog to "Red Gear" appearances
  6. Log out, change zones, change maps, all tried
  7. Both sets correctly preserve "Red Gear" appearances

I also tried first doing individual transmogs of gearset pieces before and after applying sets, but still Transmog seems to always be working. Is anyone having a way for this to reliably cause the bug to occur?

Helias commented 1 year ago

If the bug is not reproducible I am closing this issue, if someone encounter the bug again let's open the issue and write a comment about how to reproduce step by step the bug please.