azerothcore / mod-weekend-xp

XpWeekend module for Azerothcore
17 stars 19 forks source link

Issue compile source #17

Closed Th3AnG3L closed 1 year ago

Th3AnG3L commented 1 year ago

Hello i have download this module and try to install it on latest version on AzerothCore, Cmake detects the module and no errors shows, then Generate and Open Project with visual studio 2019 But when i try Clean>Build the project it gives error If i remove the module it builds without issues.

Severity Code Description Project File Line Suppression State Error LNK2019 unresolved external symbol "void __cdecl AddWeekend_XPScripts(void)" (?AddWeekend_XPScripts@@YAXXZ) referenced in function "void __cdecl AddModulesScripts(void)" (?AddModulesScripts@@YAXXZ) worldserver D:\WoW\Build\src\server\apps\modules.lib(ModulesLoader.obj) 1

Th3AnG3L commented 1 year ago

found the issue its inside your module. Correct it like this: WXP_loader.cpp and change the function name to AddMod_Weekend_XPScripts Then it will allow to be build correct.

Suggestion: how to make to display icon as Buff when Weekend Start. I want to show some icon and tooltip when mouse over to display its started?

Helias commented 1 year ago

please, if the issue is not fixed in this repository leave it open Moreover, you could propose the fix of the compilation via Pull Request

Th3AnG3L commented 1 year ago

Hello, i do not know is coming from module issue or from CMake issue, but if some users may have this issue the same as me, they can follow this steps to solve it. Really do not real cause of Upper Case and LowerCase reading when building. Please can you include in project to show Icon on character like buff skill that the double EXP weekend started? it would be really good im trying to find a way how to make this.

Helias commented 1 year ago

I did not work on this module, hope the author can help you. I am closing the issue, if this issue will be encountered from other users I will re-open it