azerothcore / mod-zone-difficulty

Support module for mod-progression-system, handles nerfs and debuffs per zone.
GNU Affero General Public License v3.0
19 stars 25 forks source link

Adding Content types > 9 or Item Types > 9 will cause crash #36

Closed Aniquilo closed 11 months ago

Aniquilo commented 12 months ago

Hello, thanks in advance for taking your time to do this, really appreciated.

Found out that if i use more content types for reward npc or i create new item types higher than 9 actions go higher than the selected gossip menu so they try to selected the next content type or item type which is + 1 without any itemtype or counter.

For ref if you add TYPE_RAID_T5 or higher to zone_difficulty_mythicmode_rewards which is located at:

https://github.com/azerothcore/mod-zone-difficulty/blob/master/src/ZoneDifficulty.h#L91

You will get a crash on line https://github.com/azerothcore/mod-zone-difficulty/blob/master/src/mod_zone_difficulty_scripts.cpp#L928 when you click on the desired gossip.

Also if you want to add new ItemTypes:

https://github.com/azerothcore/mod-zone-difficulty/blob/master/src/ZoneDifficulty.h#L104 higher than 9

You will also get a crash if you click on the gossip, dunno for what reason this is happening:

image

Again, thanks, appreciated.

55Honey commented 12 months ago

It's not possible to check the cause of crashes without a full crashlog and the source. Please upload the crashlog to e.g. a gist or pastebin and link it here.

55Honey commented 11 months ago

No link to the fork provided, no crashlog, closing.