azet / community_bash_style_guide

Community Bash Style Guide: writing useful and modern bash scripts, seriously.
Creative Commons Attribution 4.0 International
298 stars 37 forks source link

Added a couple useful tips for variable manipulation and file layout #5

Closed rothgar closed 9 years ago

azet commented 9 years ago

@rothgar Thanks, that's a good addition.

One thing: Most variables should be set by functions anyway. Some may still be global, I agree. It should maybe mention constants and that only global variables are meant. See inline comment.

Is it ok for you to add another commit changing these?

rothgar commented 9 years ago

Better? I just changed the readonly/global wording

azet commented 9 years ago

Perfect. Thank you for your contribution.