search

azet / community_bash_style_guide

Community Bash Style Guide: writing useful and modern bash scripts, seriously.
Creative Commons Attribution 4.0 International
298 stars 37 forks source link

Add a section about not hardcoding assumptions about the system #9

Closed robrwo closed 3 years ago

robrwo commented 9 years ago

Don't hardcode assumptions about the system when they can be queried, e.g. don't assume a user's home directory is in /home/username. Get it by running getent passwd username | cut -f6 -d:.

azet commented 9 years ago

Would you be willing to contribute such a section in a PR?

thanks, Aaron

azet commented 9 years ago

@robrwo any update?

robrwo commented 9 years ago

@azet no, I've been busy the past couple of months.

azet commented 9 years ago

@robrwo no worries. take your time!

azet commented 9 years ago

@robrwo

As there's no progress I'm closing this for now. Feel free to open a pull request once this work has been done and reference this issue in it.

robrwo commented 9 years ago

I've been busy, and it's on my to-do list.

azet commented 9 years ago

@robrwo sure, no problem. would you like me to re-open the issue?

ideally I'd wait until there's some progress.

robrwo commented 9 years ago

When I have something, I'll write a pull request. But I'd leave the issue open as a reminder.

azet commented 7 years ago

@robrwo ping?

robrwo commented 7 years ago

I'm still thinking about this. Busy.

azet commented 3 years ago

As there has been no progress in six (6) years, with the last comment from beginning of 2017 (four years ago), I'm going ahead and will close this ticket. You may re-open it, if you think it's appropriate. Although in that case I'd prefer a pull request with suggested changes for us to review, instead of a duplicate issue.

All the best, Aaron