azfarulmatin / pe

0 stars 0 forks source link

Wrong order for find Command #1

Open azfarulmatin opened 11 months ago

azfarulmatin commented 11 months ago

Steps to Reproduce:

Launch the program and navigate to the find functionality. Enter the command with the date first, followed by the type. Complete the find operation.

Expected Result:

Based on the user guide, it should be entered in the specific order.

Screenshot: image.png

Actual Result:

The system accepts the wrong order in the Find command without displaying any error message.

Screenshot:

image.png

Comments:

The acceptance criteria for the find command should include validation against wrong order to prevent unintended behaviour.

soc-se-bot commented 11 months ago

Team's Response

The find command is made in such a way that users are able to find any past inputs as long as it matches the relevant fields with /t being a compulsory field. And hence. The suggestion of following the specific format for the find command is just to follow the previous commands to ensure that users will not be confused.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I believe maintaining a consistent order for commands is less confusing for users. If the order of the command is merely a suggestion, users might assume they can input any format for other commands, potentially leading to more confusion. It also contradicts with their user guide as they say the fields 'should be in the specified order'. As an illustrative example on why it could confuse the user with other commands, I swapped the parameters for /cat and /t in the Add Command, and it still accepted the input, even though the 'cat' command is supposed to accept only three inputs: food, transport, and utilities, as outlined in the program and user guide.

From this screenshot, you can see that I have input the cat and type wrongly, as cat is only supposed to accept either food, transport, or utilities.

image.png

This is in their user guide:

image.png

While I understand that the Add Command is a separate issue, the main concern remains that allowing random orders can increase user confusion. Users may inadvertently enter the wrong command and still succeed, undermining the clarity and consistency of the system. Thus, I believe this is still a functionality bug.