azgs-geomapmaker / geomapmaker

A new toolbar for making geologic maps in the ESRI ArcPro environment.
MIT License
5 stars 2 forks source link

Change names of MAP UNIT POLYS buttons #73

Closed aazaff closed 2 years ago

aazaff commented 2 years ago

The draft README describes the:

Currently the map unit polygons buttons are as follows:

  1. Create Map Unit Polys
  2. Edit Map Unit Polys
  3. Generate all polygons

I find the first two names somewhat inapt as the "Create Map Unit Polys" name implies creating more than one polygon. I think we should emphasise that this button is for creating ONE map unit at a time. Alternative name suggestions I have are: CREATE SINGLE MAP UNIT POLY, ADD SINGLE MAP UNIT POLYGON, ADD MAP UNIT POLYGON, CREATE MAP UNIT POLYGON.

Similarly, the edit map unit polys while technically accurate doesn't really convey what the button is for. Maybe something like Assign Map Unit to Polygons? Rename Map Unit Polygons?

What do you (@mcamp1) think about these alternative names?

aazaff commented 2 years ago

If I were to design this all over again, I think rather than three buttons - there would just be one button for creating polygons (whether all or individual) and one button for assigning existing polygons to a map unit. That's conceptually cleaner. Perhaps this is something we will look into in v3.0 update, but for now. We will just try renaming the buttons.

aazaff commented 2 years ago

okay, I figured it out. What we really need to do is just move the "generate all polygons" button inside of the create polygons button. There's no reason for them to be separate, since the generate all polygons button is effectively the same as just doing a select all on the contacts and faults and then using the create polygons button. Anyway, this is a change for 3.0 not right now.

aazaff commented 2 years ago

I've settled on, for now, leaving generate all polygons as is, but changing "Create map unit polys" -> CREATE POLYGON(S) FROM CONTACTS and "edit map unit polys" -> EDIT MAP UNIT OF POLYGON(S) @mcamp1