azgs / azlibrary_database

1 stars 1 forks source link

How are incomplete azgs.json handled? #9

Closed aazaff closed 5 years ago

aazaff commented 5 years ago

If you got an incomplete azgs.json - i.e., where all of the provided keys and values are valid, but not all keys are included. How does the upload app handle that? Throw an error?

{
        "title": "Geologic Map and report of the Cibola Area",
        "authors": [ 
                {"person": "Brian F. Gootee",
                "organization": "Arizona Geological Survey",
                "givenname": "Brian",
                "surname": "Gootee"},

                {"person": "Phil Pearthree",
                "organization": "Arizona Geological Survey",
                "givenname": "Phil",
                "surname": "Pearthree"}                          
                ],
        "collection_group": {
                "name": "Digital Geologic Maps"
                }
}
NoisyFlowers commented 5 years ago

If I reply to these emails, does the Github Issue update automatically?

Collection upload will fail if:

On Mon, Feb 18, 2019 at 12:12 PM Andrew Zaffos notifications@github.com wrote:

Assigned #9 https://github.com/azgs/azlibrary_database/issues/9 to @NoisyFlowers https://github.com/NoisyFlowers.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/azgs/azlibrary_database/issues/9#event-2147076537, or mute the thread https://github.com/notifications/unsubscribe-auth/AL925ALjWWK-xbqPts4PzGdQ0pQhJu7nks5vOvsRgaJpZM4bBd45 .

aazaff commented 5 years ago

Yes, email replies will automatically update github, but it will send the full header of stuff which is annoying.