azhon / AppUpdate

Android App update library. Android版本更新库,简单、轻量、可随意定制
Apache License 2.0
2.23k stars 326 forks source link

skip md5 check if hash value is empty #144

Closed thinhbuzz closed 1 year ago

thinhbuzz commented 1 year ago

save the cost of checking md5 when the hash is empty.

azhon commented 1 year ago

I think check if hash value empty is unnecessary, finally FileUtil.md5(file).equals(manager.apkMD5, ignoreCase = true) always return false.

thinhbuzz commented 1 year ago

@azhon in the current behavior we still need the cost to generate the md5 hash for comparison. with this PR we don't need to generate md5 hash

azhon commented 1 year ago

@thinhbuzz sure. add this PR in the next version