Fixing issue #73: debugging snippet gets in the way

azicchetti / jquerymobile-router

A router/controller for jquery mobile. Also adds support for client-side parameters in the hash part of the url. The routes handles regexp based routes. This plugin can be used alone or (better) with Backbone.js or Spine.js, because it's originally meant to replace their router with something integrated with jQM.

GNU General Public License v2.0

402 stars 69 forks source link

Fixing issue #73: debugging snippet gets in the way #75

Closed mzedeler closed 11 years ago

mzedeler commented 11 years ago

Two notes:

I am just starting to test this now, so this pull request is sent in order to get a code review.
I have added the option to specify debugHandler: null in order to disable debugging entirely. It is an odd way of doing so, but will preserve backwards compatibility.

mzedeler commented 11 years ago

Sorry. This is horribly broken. Will do another.

mzedeler commented 11 years ago

This should be it.

I have removed the debug function and made it a method on the router prototype. Tested all three cases:

Using console.log (default).
Using a custom handler (just try function(err){throw err} for kicks).
Debugging disabled.

The first method above may still fail on some browsers, but it shouldn't be any worse that before.

azicchetti commented 11 years ago

Thank you, your patch has been merged in the latest commit. I've just changed the value to disable debugging, since false seems easier to remember than null.

Thanks again for putting your time into this.

mzedeler commented 11 years ago

Sure. No problem. I had an itch...