search

azimuth-cloud / capi-helm-charts

Apache License 2.0
16 stars 18 forks source link

Truncate secret names to prevent going over 63 char limit. #390

Closed dalees closed 1 month ago

dalees commented 1 month ago

Some secrets created for very long cluster names were going over the 63 char label limit of Kubernetes, and were not deploying.

Example error message: failureMessage: 'HelmRelease.addons.stackhpc.com "reallylongnamecluster1reallylo-oe62woigm3qq-ccm-openstack" is invalid: metadata.labels: Invalid value: "secret.addons.stackhpc.com/reallylongnamecluster1reallylo-oe62woigm3qq-ccm-openstack-config": name part must be no more than 63 characters'

mkjpryor commented 1 month ago

@dalees

We also noticed this, and fixed it in the addon provider instead:

https://github.com/azimuth-cloud/cluster-api-addon-provider/pull/115

It isn't in a released version yet, but will be soon.

dalees commented 1 month ago

@dalees

We also noticed this, and fixed it in the addon provider instead:

azimuth-cloud/cluster-api-addon-provider#115

It isn't in a released version yet, but will be soon.

Thank you @mkjpryor - I'll test and look to update our provider to this instead!