azimuth-cloud / capi-helm-charts

Apache License 2.0
16 stars 20 forks source link

check if cri registry is already defined before setting it #410

Closed anish-mudaraddi closed 1 month ago

anish-mudaraddi commented 1 month ago

There was an update made to the upstream k8s image builder - https://github.com/kubernetes-sigs/image-builder/blob/v0.1.34/images/capi/ansible/roles/containerd/templates/etc/containerd/config.toml#L14-L15

Which means that this setting was not needed - but to enable backwards compatibility we check if the containerd config file already contains the value before setting it

mkjpryor commented 1 month ago

Superseded by #415