azinchen / nordvpn

NordVPN Docker Client
GNU Affero General Public License v3.0
97 stars 19 forks source link

Unrecognized option or missing or extra parameter #417

Closed Joly0 closed 5 months ago

Joly0 commented 8 months ago

Hey, i tried adding the following variable: -e 'TECHNOLOGY'='pptp' and after starting up, i get this error constantly: Options error: Unrecognized option or missing or extra parameter(s) in /tmp/nordvpn.ovpn:3: proto (2.6.8) Use --help for more information.

Joly0 commented 8 months ago

Ok, from looking at thise function https://github.com/azinchen/nordvpn/blob/8eb11217d3d23b861be28b836e3a81216a836def/root/usr/bin/createvpnconfig.sh#L147 there seems to be 2 issues here. First this line https://github.com/azinchen/nordvpn/blob/8eb11217d3d23b861be28b836e3a81216a836def/root/usr/bin/createvpnconfig.sh#L151 should be ident=$(echo "$nvtechnologies" | jq -r --arg NAME "$input" 'select(.identifier == $NAME) | .identifier')

(i think this applies to https://github.com/azinchen/nordvpn/blob/8eb11217d3d23b861be28b836e3a81216a836def/root/usr/bin/createvpnconfig.sh#L132 aswell)

and second the function only returns something, if the ident variable has udp or tcp in it, which is not the case for technologies like pptp

azinchen commented 8 months ago

@Joly0 , the azinchen/nordvpn image supports OpenVPN protocol and technologies only.

Joly0 commented 8 months ago

Ok? Then maybe adjust your technology list here https://github.com/azinchen/nordvpn/blob/master/TECHNOLOGIES.md It indicates, that all these technologies are working and supported

azinchen commented 8 months ago

It is mentioned in the list of environment variables.

Joly0 commented 8 months ago

Hm, ok. Wasnt that obvious to me. But thanks