search

aziz / PlainTasks

An opinionated todo-list plugin for Sublime Text editor (version 2 and 3)
MIT License
3.29k stars 286 forks source link

Introducing less "toxic" variation of [eighties-colored] theme #376

Closed dkalcheu closed 6 years ago

dkalcheu commented 6 years ago

I like the original [eighties-colored] color theme, but I found default colors for priority tags too "toxic." For example, the red background color of "critical" and "due" tags just kills my eyes. I made a couple of changes in the colors and styles to decrease the numbers of overall colors used in the theme so that trying to convert it to a more human-friendly view. Hopefully, you will find it useful.

vovkkk commented 6 years ago

It would be nice to see a screenshot comparison.

Another concern is do we really need another bundled scheme esp. if it is a slight modification of another one? I would like to keep the size of code base in reasonable range, so…

dkalcheu commented 6 years ago

Please, find the screenshots BEFORE and AFTER the change attached.

BEFORE:

sample todo list - before

AFTER:

sample todo list - after

What concerns adding a new file vs. modifying an existing one, I would also vote for changing the existing color schema. I just wanted to get a feedback before doing that :)

vovkkk commented 6 years ago

Ah, that’s definitely an improvement! Let’s fix the existing scheme. Those colours were simply copied from default scheme, the one with yellow background, so they indeed look out of place.

dkalcheu commented 6 years ago

Thank you! I will cancel this PR and create a new one by modifying existing color schema.

vovkkk commented 6 years ago

You can push another commit with changes here, there is no need to send other pr, I mean I don’t mind either way, just fyi.