aziz / SublimeFileBrowser

Ditch sidebar and browse your files in a normal tab with keyboard, like a pro!
MIT License
394 stars 46 forks source link

Opening a project from the jump list always have a sublime error popup #94

Closed aziz closed 9 years ago

aziz commented 9 years ago

Here is how to recreate: Add a project to the jump list. open the jump list view and press enter on one of those projects. you should see a popup with this message.

"dired_index" is empty,
that shouldn’t happen ever, there is some bug.
vovkkk commented 9 years ago

This issue is fixed in x-refactoring branch, which is mostly finished, btw, I’ll release next weekend.

The actuall fix for current version is simple as:

--- C:\Users\vova\AppData\Roaming\Sublime Text 2\Packages\FileBrowser\dired.py Sat Sep 05 19:02:33 2015
+++ C:\Users\vova\AppData\Roaming\Sublime Text 2\Packages\FileBrowser\dired.py Sat Sep 05 19:10:05 2015
@@ -1145,10 +1145,10 @@

 class DiredOpenInNewWindowCommand(TextCommand, DiredBaseCommand):
     def run(self, edit, project_folder=False):
-        self.index = self.get_all()
         if project_folder:
             files = project_folder
         else:
+            self.index = self.get_all()
             files = self.get_marked() or self.get_selected()
         items = []

But let’s not release it, to avoid merge conflicts, please?

aziz commented 9 years ago

It's all right. We can wait for your awesome refactoring.