aziz / knockdown

Github flavored Markdown for SublimeText and a custom theme for writing markdown
89 stars 17 forks source link

In lists bold and italics are sometimes highlighted/recognised and sometimes not #7

Open mickimnet opened 11 years ago

mickimnet commented 11 years ago

In my README.md, what I'm currently udpating, I've the following code:

### Version 1.3

1. *major change*: added support for `Markdown` (including `GitHub Flavored Markdown` ) through the package [knockdown](https://github.com/aziz/knockdown)
2. *major change*: added support for `reStructuredText` and updated coloring for `reStructuredTextExtended`
3. *major change*: changed highlighting for (`Git`)`DIFF` output/files, added support for `GitGutter`
4. *major change*: regarding "Line highlighting": it is nearly impossible to have one color which works with `highlight_line` turned on or off.  And as I don't use that, I added a second in the tmTheme file for those who do use `highlight_line`. See above for a short description how to change the
5. *change*: removed extra color of "function arguments", but they are still rendered in "*italics*"
6. *minor change*: adjusted the bracket colors to fit the "Orange" scheme

1. *italics text* is not working *italics* is working
2. **bold text** is working as well as **bold**
3. This is another test line with *italics text* in it. 
4. So, *italic text* is not working at the beginning of the line
5. _italics_ is working as well
6. *italic text* is working, no call me confused.
7. _italic text_ 

The first list was created without the numbers in the first column (the text started just with ". major change: ...") and I added the numbers just now--and it doesn't make a difference in the highlighting (meaning: no highlights for bold/italics)

The second list, was just typed in from the beginning to the end, including the line numbers. See the following image for how it is rendered on my system: SublimeText-knockdown-strange

My personal guess is, that if your syntax highlighter discovers the first line of a list, it stops checking for bold/italics, and as my first list kind of consists of only first lines (without the numbers), it makes sense to me.

mickimnet commented 11 years ago

Some amends:

mickimnet commented 11 years ago

Amend:

after further testing, I figured why _change_: is not recognized: remove the ":" after the last "_" and it works.

aziz commented 11 years ago
  1. italic that has a space before at the beginning of sentence is not recognized
  2. italic that has a bullet (*/+/1.) before it, is not recognized
  3. italic that has a colon after is not recognized