search

azizilab / starfysh

Spatial Transcriptomic Analysis using Reference-Free auxiliarY deep generative modeling and Shared Histology
BSD 3-Clause "New" or "Revised" License
99 stars 12 forks source link

Potential Bug in `IntegrativeDataset` #44

Closed psl-schaefer closed 4 months ago

psl-schaefer commented 4 months ago

If I understand the code correctly IntegrativeDataset is actually used if we run the model without H&E image so self.image can/should be None (in contrast to IntegrativePoEDataset where indeed self.image should not be None. These are the lines I am referring to: https://github.com/azizilab/starfysh/blob/7407267515d56a7dc96672c764a40635fae581d6/starfysh/dataloader.py#L113-L132

YinuoJin commented 4 months ago

Hi schae211,

Yes you're right thanks for the the reminder. Running without histology integration (PoE) indeed doesn't require the paired image. By default we load the image metadata anyway so the assertion error doesn't get triggered. We will update the code.