azizkayumov / flashcard-maker-android

Flashcard Maker is an android app that allows you to create and import e-flashcards for convenient, paperless studying.
https://play.google.com/store/apps/details?id=com.piapps.flashcardpro
GNU General Public License v2.0
63 stars 22 forks source link

Flipping the cards direction #13

Closed greyboxgt closed 4 years ago

greyboxgt commented 4 years ago

This is probably an easy one. I would like to always rotate the cards clockwise when flipping between front and back side. Perhaps, a mod in FlipAnimation.kt?

Thank you!!

azizkayumov commented 4 years ago

Isn't working in the way you described?

Engineerator commented 4 years ago

It actually flips clockwise when flipping from front side to back side and counterclockwise when flipping from back side to front side. @greyboxgt asked the card to always flip clockwise.

I think I found a solution to this request. In the FlipAnimation.kt these line of code controls which way the card flips:

if (forward) degrees = -degrees //determines direction of rotation when flip begins

Commenting these lines out flips the card clockwise each time it is rotated. Maybe the users can be given an option to choose which direction the card flips?

Daniel.

greyboxgt commented 4 years ago

To me the current animation feels counter-intuitive because your current icon is actually a clockwise arrow, but the card rotates clockwise and counterclockwise. Maybe having two icons side by side - one for clockwise and another for counterclockwise rotation would be a better option?

azizkayumov commented 4 years ago

Solved in #14

greyboxgt commented 4 years ago

Thank you guys for this fix! Feels much better now! Like a card, not like a book! ;-)