azizkayumov / flashcard-maker-android

Flashcard Maker is an android app that allows you to create and import e-flashcards for convenient, paperless studying.
https://play.google.com/store/apps/details?id=com.piapps.flashcardpro
GNU General Public License v2.0
63 stars 22 forks source link

Icons consistency in different modules #28

Closed greyboxgt closed 3 years ago

greyboxgt commented 3 years ago

I noticed that the same function icons in different modules are not always consistent. For example, to exit from the editing module we use the "back arrow" ← icon, but to exit from study and exam we use the "X" icon. But "X" in editing module deletes the card for good! Back arrow ← is also used to select the previous card. I would suggest to use the "less than" "<" icon to exit from any module:

editing module-s


Study module would look like this:

study module-s


In study module all the icons are consistent with the editing module. But in exam module the red "eye" and green "check" icons are too distracting. I would suggest the "rotation" icon on the right side and "check" icon on the left side similar to editing module for consistency, so exam module would look like this:

exam module-s2


On the main screen the new set creation icon is currently white "plus" in red circle. I would suggest the grey "plus" in white fill circle and dark grey stroke or some shadow to be consistent with editing module "add a new card" icon:

main module

azizkayumov commented 3 years ago

Thank you for feedback.

I think "←" should stay the same as it is since the official design guidelines show that "←" icon is used for Appbars. Study & Quiz modules should use the "←" icon too (pushing the change below). Let's change the "next" and "previous" icons to "<", ">" to make it different from "exiting".

Regarding to the floating action buttons (circle buttons), I would follow the official guidelines. As far as I understand from the guidelines, the floating action buttons should represent the primary actions of a screen: marking the card as "Yes, I know" or "No, I don't remember" in Quiz module and "Create a new set" on the Main screen. I don't think a light circle button with dark border follows the Material design as it has 3 elements: surface+border+icon, while it would be a combination of just 2 elements: surface+icon.

greyboxgt commented 3 years ago

Thank you for fixing the "back" icon!

The standard Google rainbow "plus" on white background icon seems to have the shadow to make enough contrast even with white card set. And the rainbow "plus" could reflect the fact that your newly created card set has a random initial color:

white button

I still think that current green/red/ Yes/No buttons are too bright and distracting for the exam. Maybe neutral colors happy/sad smileys will agree with the guidelines?

exam module-s2

azizkayumov commented 3 years ago

Removed the distracting buttons from Quiz module and replaced them with simple "flip" and "check" buttons, feel free to reopen the issue if something can be improved further:

device-2020-10-26-120517

azizkayumov commented 3 years ago

I noticed that you create flashcards with sentences (not just words on each side), I think sentences are more efficient and worth remembering than just words. Usually, I create flashcards with just words, so I always have a hard time finding an appropriate word when I speak or want to explain something. Let me know more about your experience how to use the app efficiently.

greyboxgt commented 3 years ago

Thank you very much for fixing this!

I use everything: words, phrasal verbs, sentences, idioms. From my experience, the set should be 20 cards maximum. I often shuffle the cards (thank you for this feature!) After some cards are learned, I move them to a temporary (monthly) archive (thank you for this wonderful feature!), and add new cards. About a month later I load that archived set and delete the cards I think I learned. If I have a problem with some cards, I move them back to the current set.

One thing I can tell you this application became a part of my life. I hope you will be able to share your Flash Card Maker with other people, so they can benefit from it. A few feature requests are still outstanding. The most important to me would be Excel import-export (#9) and Drag & drop to change set order (#27).

azizkayumov commented 3 years ago

Thank you for sharing your experience, I need to definitely remake my flashcards, I have about 50 flashcards on average, so my sets are really challenging to learn, 20 flashcards would be a perfect frequency. So happy to hear that you find the app helpful. I usually contribute to the app in weekends, I hope I will be able to push the feature requests soon.