search

azizkayumov / flashcard-maker-android

Flashcard Maker is an android app that allows you to create and import e-flashcards for convenient, paperless studying.
https://play.google.com/store/apps/details?id=com.piapps.flashcardpro
GNU General Public License v2.0
63 stars 22 forks source link

The card font size #7

Closed greyboxgt closed 3 years ago

greyboxgt commented 4 years ago

The font size is too big for some words. Users should be able to pick up and configure the font they want by a pinching motion and/or by pressing +/- icons. As a quick workaround @Engineerator suggested changing textSize from 32F to 28F, but it would be nice to give users a chance to set the font size they want.

azizkayumov commented 3 years ago

This commit adds a font size editor for card front and back texts. The editor sets the font size for a card side that is visible, so two card sides' font sizes must be set separately: device-2020-09-26-145151 Let me know if that works for you.

azizkayumov commented 3 years ago

I think it would be nice to have an option to change all cards' font sizes.

azizkayumov commented 3 years ago

I think the last commit can close the issue, feel free to reopen it if something comes up. device-2020-09-26-153441

greyboxgt commented 3 years ago

Works very well, thank you very much for adding this feature!!!

greyboxgt commented 3 years ago

Would it be possible to add pinch-zoom gesture to change the font size in addition to "Set the card font size" menu option?

azizkayumov commented 3 years ago

That's a good idea! In terms of user experience, how would you imagine setting the font size for all cards after pinch-zoom gesture?

greyboxgt commented 3 years ago

I think the same font size for all cards in the deck will work very well. And it will probably be easier to implement.

greyboxgt commented 3 years ago

If you are going to implement the pinch-zoom gesture feature, you may want to re-open this issue.

azizkayumov commented 3 years ago

Indeed, that would be a great enhancement. With the pinch-zoom gesture, how should we ask the user whether he wants to set the new font size to all cards or to a single card he's pinch-zooming? Like should I display a dialog with "Would you like to set the new font size to all cards?" right after the pinch-zoom gesture?

greyboxgt commented 3 years ago

I still think that same font size for all cards within the card set will work very well and it will probably be easier to implement. And you already used the same approach for the card set colors.

azizkayumov commented 3 years ago

The last commit adds the pinch-zoom gesture to change the card text size. The changes must be visible in a few hours in Open testing. Let me know if that works for you.

greyboxgt commented 3 years ago

Works very well, thank you very much!!