azizkayumov / flashcard-maker-android

Flashcard Maker is an android app that allows you to create and import e-flashcards for convenient, paperless studying.
https://play.google.com/store/apps/details?id=com.piapps.flashcardpro
GNU General Public License v2.0
63 stars 22 forks source link

Font type and background colors #8

Closed greyboxgt closed 3 years ago

greyboxgt commented 4 years ago

Is it possible to add more font background colors? My favorite would be orange font on black background.

It would also be nice to give users a chance to change the font type. Some fonts like Sans Forgetica are designed using the principles of cognitive psychology to help you to better remember your cards.

azizkayumov commented 4 years ago

@greyboxgt SansForgetica website states that:

Sans Forgetica is designed for non-commercial use only. It is bound by a creative commons, non-commercial, attributed (CCBYNC) license.

So can I use it since this app is open-source and non-commercial (free & ad-free)? Here I tried to use the font in Study module: device-2020-04-11-175556

azizkayumov commented 4 years ago

Unfortunately, SansForgetica does not work on Cyrillic words, its font design contains only latin letters:

Screen Shot 2020-04-11 at 18 16 48
greyboxgt commented 4 years ago

I didn't know, sorry. I only heard this font helps to memorize text. Do you know it it would be legal for me or somebody else to modify the original font and add the missing characters?

With your initial approach, can a user select ANY font, or the font has to be hard coded?

And for the colors, I looked at your older Flashcard application and there was an option to select any HEX color. Maybe you could re-introduce this option?

azizkayumov commented 4 years ago

Nope, one cannot select ANY font, I just downloaded the font and tried it, you guys may want to try it as well, it is on a separate branch: https://github.com/AbduazizKayumov/Flashcard-Maker-Android/tree/forgetica

Yes, I will add the color wheel in the next commits.

greyboxgt commented 3 years ago

Yes, the color wheels for the font and the background would be a very nice feature!

azizkayumov commented 3 years ago

The last commit removes default colors and adds color wheel for any color picker (set color, card background or card text color). I ended up using this library: device-2020-10-05-001511 Let me know if anything could be improved.

greyboxgt commented 3 years ago

The color wheel is a very nice addition, thank you very much for this fantastic feature!!!

I have a few notes/suggestions:

  1. When changing the card text color we cannot always see the actual text on the screen because the color wheel window is most of time bigger than the text on the screen behind it. And also with many background colors the default icons color doesn't show enough contrast. But because we can always see the "pencil" and the "X" icons on the top, we can also use the same color attribute for the text and for all four corner icons to see the result immediately while picking up the text color. This should resolve the problems I just mentioned and should also look much better that way.

  2. You currently have color wheels for the font and the background of the individual cards, but the color wheel for the card set is designed only for the background. And if we set the new card set background color, it overwrites the previously defined individual cards text and background colors. To resolve this and simplify the process similar to what you are going to do to the font size, we could to get rid of individual card colors and use the same text and background colors for the entire card set. You would need to add the A color wheel icon to set the card set text.

azizkayumov commented 3 years ago

Thank you for your feedback. Yes, I think the same text and background colors for all set cards would be a reasonable choice for everyone. The last commit fixes the 2 issues you mentioned above. Let me know if that works for you.

greyboxgt commented 3 years ago

Works great and looks very nice, thank you very much for the update!

Screenshot_2020-10-10-12-22-57