line ending symbols bug

aziznal / dart-import-sorter

A vscode extension that groups and sorts imports for dart files (https://marketplace.visualstudio.com/items?itemName=aziznal.dart-import-sorter)

MIT License

14 stars 1 forks source link

line ending symbols bug #44

Closed NANI-SORE closed 2 years ago

NANI-SORE commented 2 years ago

When looking for app name extension splits package.yaml by '/n', but does not remove '/r' therefore breaking app name detection i.e. 'name: app_test' becomes 'app_test/r'

I fixed it by wrapping return in getProjectNameFromPubspecFile with Utils.removeNewLines

aziznal commented 2 years ago

I see. I appreciate your contribution. Would you like to create a PR with the fix? Your name will appear in the contributors section that way.

NANI-SORE commented 2 years ago

Sure, pushed a PR here https://github.com/aziznal/dart-import-sorter/pull/45