search

azizur / arabic-ligature

Arabic Ligature
21 stars 2 forks source link

minor documentation issue: سبحانه و تعالى #7

Open huttarl opened 2 years ago

huttarl commented 2 years ago

In the README.md, the last line of the table of ligatures says

[swt][jallajalaluh][jallajalalouhou] | ﷻ | سبحانه و تعالى | Jalla Jalāluhu

The Arabic there (سبحانه و تعالى) doesn't match the transliteration (Jalla Jalāluhu) or the ligature. My guess is that the Arabic (سبحانه و تعالى) matches the short code [swt].

Maybe the two phrases are synonyms, but it's a bit confusing to have one phrase in the Arabic and the other phrase in the transliteration.

azizur commented 2 years ago

@huttarl Apologies for the lack of response on this issue. I would appreciate a PR on this if you have some time.

huttarl commented 2 years ago

Sorry, @azizur, I don't know enough about the usage of these phrases to know what to suggest as a solution. I'm not sure why [swt] and سبحانه و تعالى are in this line of the documentation at all. As far as I can tell, there is no ligature in Unicode for سبحانه و تعالى itself. So did you include them together with Jalla Jalāluhu / ﷻ because they are synonyms?