search

azkaban / azkaban-plugins

Plugins for Azkaban.
https://azkaban.github.io
Apache License 2.0
130 stars 178 forks source link

Added autofocus and enter button support to HDFS proxy user modal #270

Closed jackrjli closed 7 years ago

jackrjli commented 7 years ago

This JavaScript tweak gives focus to the text input after clicking on the "Change User" button in the HDFS Browser, so the user doesn't have to click in the box before typing.

Additionally, while the text input is focused, this change gives the Enter key the same behavior as clicking the submit button, so the user can simply type the proxy user name and press enter rather than having to click on the submit button.

Testing Done: Pasted the script into the Javascript console (Firefox and Chrome) while on the HDFS browser page and tried switching proxy user to verify the changes.

HappyRay commented 7 years ago

Thanks for the pull request!

@kunkun-tang does it look good to you?

kunkun-tang commented 7 years ago

LGTM. How did you test your change? @jackrjli

HappyRay commented 7 years ago

LGTM, could you please add a testing section to your change description?

jackrjli commented 7 years ago

I tested this change by pasting the modified script into the JavaScript console (both Firefox and Chrome) while on the HDFS browser page and verifying the changes manually. I added this info to the description above.