azlux / pymumble

Mumble client implementation in Python
GNU General Public License v3.0
129 stars 61 forks source link

Change SSL code to be compatible with Python 3.12 #135

Closed Eswcvlad closed 10 months ago

Eswcvlad commented 10 months ago

The ssl.wrap_socket function was deprecated in 3.7 and now it is fully removed in 3.12.

The logic, that the code does not validate the server certificate in any way, has been preserved for compatibility reasons, but this is pretty insecure and, ideally, should be a configurable option.

azlux commented 10 months ago

Thank for the implementation. The compatibility is a currently a good thing even if unsecure.