Ready for review

[azoff]

@nesquena @timothy1ee

Hey guys, my app is ready to disrupt the 2001 app industry. Please review.

[timothy1ee]

Impressive. How long did that take you?

[azoff]

All day. You forget I don’t have a job :)

On Friday, March 14, 2014 at 6:31 PM, Timothy Lee wrote:

Impressive. How long did that take you?

— Reply to this email directly or view it on GitHub (https://github.com/azoff/codepath-ios-rottentomatoes/issues/1#issuecomment-37711902).

[timothy1ee]

Good job! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. Very nice implementation, good visual polish as well. Small detail, but az_ is a non-standard way of prefixing your classes, you should consider using AZ with no underscore.

For your information, here is the checklist that I use when I review the homework:

• Code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
• Movie model. Did you have some way to create it from a dictionary?
• You should have implemented a custom cell. When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
• You should have loaded all the images asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
• You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• If you had a custom cell, you should configure the Auto Layout parameters. We'll review that in class.
• Did you display some loading indicator while you were fetching the movies.
• Did you display an error if you failed while fetching the movies.