azoff / codepath-twitter-client

2 stars 1 forks source link

[Android Bootcamp] App Ready for Review #1

Open azoff opened 10 years ago

azoff commented 10 years ago

App's ready, please review. /cc @nesquena

Pain points:

nesquena commented 10 years ago

Jonathan, :+1: excellent submission. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

nesquena commented 10 years ago

Turns out you can't set a relationship member (i.e. Tweet.user) with a Model that has not previously been save()d.

Thanks for the pain notes, added a note about the saving issue to helpful hints. I would like to fix that issue in ActiveAndroid eventually. IMO it should autosave the model rather than error out.