nesquena
commented
10 years ago Jonathan, :+1: great submission! A few notes after checking out the code:
- Really well organized code into correct subpackages
- Interesting setup for attaching the tabs semi-dynamically. Also, try following this approach for cleaner tab listeners and better memory management.
- Nice to see you used a drawable to customize the view
- Interesting choice having a single
TimelineFragmentwithout any inheritance. It adds a lot of complexity to your fragment though. I would recommend considering a few key abstract methods, hooking up the logic in the base class and then extending specialized fragment classes for each type of timeline for more maintainable code.
Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.
Week 7 (Nov 11th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.
New user stories incorporated, please review. /cc @nesquena
I didn't get to the last optional user story because I want to focus on the group project.
One interesting note: I had to rebuild the ActiveAndroid jar because the one you ship in the REST Client Template doesn't have unique key constraint support. Also, implicit foreign key constraints are broken in the latest Active Android, so I had to manage the relationships manually.